Fix #3886: add tests for dotc/dotr/dotd #3892
Conversation
.drone.yml
Outdated
| - ./dist-bootstrapped/target/pack/bin/dotr Test | ||
| - echo ":quit" | ./dist-bootstrapped/target/pack/bin/dotr | ||
| - ./dist-bootstrapped/target/pack/bin/dotd -project Hello tests/run/hello.scala | ||
|
|
There was a problem hiding this comment.
@allanrenucci I'm not sure if it's the best way to do it, could you please advise?
There was a problem hiding this comment.
I would probably merge this with project/scripts/sbt/sbtTests. The script tests the commands but within sbt.
project/scripts/cmdTests
Outdated
| ./dist-bootstrapped/target/pack/bin/dotc tests/run/hello.scala | ||
| ./dist-bootstrapped/target/pack/bin/dotr Test | ||
| echo ":quit" | ./dist-bootstrapped/target/pack/bin/dotr | ||
| mkdir -p _site && ./dist-bootstrapped/target/pack/bin/dotd -project Hello -siteroot _site tests/run/hello.scala |
There was a problem hiding this comment.
Add set -eux under #!/usr/bin/env bash otherwise the exit code of the script will be the result of the last command ran
project/scripts/sbtBootstrappedTests
Outdated
| @@ -1,5 +1,7 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
This file seems redundant to me now. I would merge it with cmdTests
project/scripts/cmdTests
Outdated
|
|
||
| ./project/scripts/sbt ";dist-bootstrapped/pack" | ||
| ./dist-bootstrapped/target/pack/bin/dotc tests/run/hello.scala | ||
| ./dist-bootstrapped/target/pack/bin/dotr Test |
There was a problem hiding this comment.
I think you can remove the three lines above. Lines 82-83 already exercise this
project/scripts/cmdTests
Outdated
| ./dist-bootstrapped/target/pack/bin/dotc tests/run/hello.scala | ||
| ./dist-bootstrapped/target/pack/bin/dotr Test | ||
| # echo ":quit" | ./dist-bootstrapped/target/pack/bin/dotr # not supported by CI | ||
| mkdir -p _site && ./dist-bootstrapped/target/pack/bin/dotd -project Hello -siteroot _site tests/run/hello.scala |
There was a problem hiding this comment.
Maybe use ./bin/dotd instead
EDIT: Oups we don't have it. My bad. Maybe add an alias?
Fix #3886: add tests for dotc/dotr/dotd